Don't export the -std=c++11 flag from the fmt target #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch and thanks for the fix! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
fmtCMake target exports-std=c++11as part of its interface; Meaning any project that links tofmthas the-std=c++11added to its compilation. However this will override the-std=<ver>flag provided by that project. This breaks projects that use C++14 or C++1z. In general I think it's bad style for projects to force a specific dialect, or any compile flags, upon its users.This patch fixes the issue by making
-std=c++11a private flag offmt. This prevent it from infecting downstream users.